Skip to content

fix redirects #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 2, 2024
Merged

fix redirects #1602

merged 6 commits into from
Jan 2, 2024

Conversation

YassinEldeeb
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 2, 2024

@YassinEldeeb is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor Author

@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to get vercel preview link to work

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:32pm

Copy link

vercel bot commented Jan 2, 2024

Deployment failed with the following error:

Redirect at index 0 has invalid `source` pattern "/conf/attendee/*".

Learn More: https://vercel.link/invalid-route-source-pattern

Copy link

vercel bot commented Jan 2, 2024

Deployment failed with the following error:

Redirect at index 0 cannot define both `permanent` and `statusCode` properties.

Learn More: https://vercel.link/redirects-json

@Urigo Urigo merged commit 5c69109 into graphql:source Jan 2, 2024
@acao
Copy link
Member

acao commented Jan 18, 2024

@YassinEldeeb @Urigo this broke redirects for swapi-graphql, can you fix them?

graphql/swapi-graphql#226

@graphql graphql deleted a comment from 11LA-PR00007 Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants